Actually disable writeback cache, instead of just claiming to do so.

joncv · Aug 6, 2017 · f8df458 · f8df458
1 parent e2a4bc9
commit f8df458
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/ChangeLog.rst b/ChangeLog.rst
@@ -1,3 +1,9 @@
+Unreleased Changes
+------------------
+
+* Truly disable the writeback cache, instead of just adjusting the
+  default and printing a warning when explicitly enabled.
+
 Release 3.1.0 (2017-08-04)
 --------------------------
 

diff --git a/sshfs.c b/sshfs.c
@@ -3901,9 +3901,11 @@ int main(int argc, char *argv[])
 		exit(1);
 	}
 
-	if(sshfs.writeback_cache)
+	if(sshfs.writeback_cache) {
 		printf("NOTICE: writeback cache is disabled in this release due to potential\n"
 		       "dataloss. It will be re-enabled in a future SSHFS release.\n");
+		sshfs.writeback_cache = 0;
+	}
 
 	if (sshfs.idmap == IDMAP_USER)
 		sshfs.detect_uid = 1;