Merge pull request prometheus#2004 from redbaron/no-false-sharing

Avoid having contended mutexes on same cacheline
joe2hpimn · Sep 18, 2016 · c9c2663 · c9c2663
2 parents 5f5a78e + bdc5309
commit c9c2663
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/storage/local/locker.go b/storage/local/locker.go
@@ -15,10 +15,21 @@ package local
 
 import (
 	"sync"
+	"unsafe"
 
 	"github.com/prometheus/common/model"
 )
 
+const (
+	cacheLineSize = 64
+)
+
+// Avoid false sharing when using array of mutexes.
+type paddedMutex struct {
+	sync.Mutex
+	pad [cacheLineSize - unsafe.Sizeof(sync.Mutex{})]byte
+}
+
 // fingerprintLocker allows locking individual fingerprints. To limit the number
 // of mutexes needed for that, only a fixed number of mutexes are
 // allocated. Fingerprints to be locked are assigned to those pre-allocated
@@ -30,7 +41,7 @@ import (
 // fingerprint at the same time. (In that case a collision would try to acquire
 // the same mutex twice).
 type fingerprintLocker struct {
-	fpMtxs    []sync.Mutex
+	fpMtxs    []paddedMutex
 	numFpMtxs uint
 }
 
@@ -41,7 +52,7 @@ func newFingerprintLocker(preallocatedMutexes int) *fingerprintLocker {
 		preallocatedMutexes = 1024
 	}
 	return &fingerprintLocker{
-		make([]sync.Mutex, preallocatedMutexes),
+		make([]paddedMutex, preallocatedMutexes),
 		uint(preallocatedMutexes),
 	}
 }