Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Density hack to improve swipe dismiss #443

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Use Density hack to improve swipe dismiss #443

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
211df80
Use Density hack to improve swipe dismiss
jocmp Oct 20, 2024
dc01f61
Use 3rd-party swipe library
jocmp Oct 20, 2024
8de74e5
Fix RTL with open PR
jocmp Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix RTL with open PR 
- saket/swipe#33
  • Loading branch information
@jocmp
jocmp committed Oct 20, 2024
commit 8de74e5d77588acae09823eaebfd3657d60b8eec
16 changes: 8 additions & 8 deletions app/src/main/java/com/capyreader/app/ui/articles/list/ArticleRowSwipeBox.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ fun ArticleRowSwipeBox(

if (swipeState.disabled) {
content()
}

SwipeableActionsBox(
startActions = swipeState.start,
endActions = swipeState.end,
backgroundUntilSwipeThreshold = MaterialTheme.colorScheme.surface
) {
content()
} else {
SwipeableActionsBox(
startActions = swipeState.start,
endActions = swipeState.end,
backgroundUntilSwipeThreshold = MaterialTheme.colorScheme.surface
) {
content()
}
}
}
4 changes: 2 additions & 2 deletions app/src/main/java/me/saket/swipe/SwipeableActionsBox.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ private fun ActionIconBox(
layout(width = placeable.width, height = placeable.height) {
// Align icon with the left/right edge of the content being swiped.
val iconOffset = if (action.isOnRightSide) constraints.maxWidth + offset else offset - placeable.width
placeable.placeRelative(x = iconOffset.roundToInt(), y = 0)
placeable.place(x = iconOffset.roundToInt(), y = 0)
}
}
.background(color = backgroundColor),
horizontalArrangement = if (action.isOnRightSide) Arrangement.Start else Arrangement.End,
horizontalArrangement = if (action.isOnRightSide) Arrangement.Absolute.Left else Arrangement.Absolute.Right,
verticalAlignment = Alignment.CenterVertically,
) {
content()
Expand Down