Skip to content

Commit

Permalink
Fix unknown marker variable (pyodide#528)
Browse files Browse the repository at this point in the history
* Fix unknown marker variable

fix-unknown-marker-variable

* Add tests for fix

* Add comments
  • Loading branch information
filips123 authored and mdboom committed Oct 11, 2019
1 parent 16c512f commit 72a410c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/micropip/micropip/micropip.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def install(
'locked': dict(self.installed_packages)
}
for requirement in requirements:
self.add_requirement(requirement, ctx, transaction)
self.add_requirement(requirement, complete_ctx, transaction)
except Exception as e:
reject(str(e))

Expand Down
4 changes: 3 additions & 1 deletion packages/micropip/test_micropip.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ def test_install_simple(selenium_standalone):
selenium_standalone.run("import os")
selenium_standalone.load_package("micropip")
selenium_standalone.run("import micropip")
selenium_standalone.run("micropip.install('snowballstemmer')")
selenium_standalone.run("micropip.install('pyodide-micropip-test')")
# Package 'pyodide-micropip-test' has dependency on 'snowballstemmer'
# It is used to test markers support

for i in range(10):
if selenium_standalone.run(
Expand Down

0 comments on commit 72a410c

Please sign in to comment.