Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to cover custom jQuery.Validate extension #9

Open
peterblazejewicz opened this issue Mar 3, 2016 · 0 comments
Open

Add test to cover custom jQuery.Validate extension #9

peterblazejewicz opened this issue Mar 3, 2016 · 0 comments
Labels
enhancement

Comments

@peterblazejewicz
Copy link
Contributor

The extension file exists and is used in markup. But - as with menulink tag, I think it should be covered by tests as it is purely this project addition to generator compared to aspnet/Templates. When update arrive with MVC markup, it could be too easy to remove that code imports. The test will cover inclusion of that custom file ('is the custom jQuery extension used in markup?")
Thanks!
jjwilliams42 pushed a commit that referenced this issue Mar 5, 2016
Changes
66b2dad 
- Add semantic.validation.min.js for consistency
- Add tests for Semantic UI overrides per #9 and #6
- Add <% namespace %> to _Layout.cshtml (missing)
- Remove title from MenuLinkTagHelper rendering per #5
- Remove commented out code and extra call to $('.class').checkbox() in Login.cshtml
- Remove commented out code in various cshtml files
- Merged in functionality to use Semantic OR Bootstrap libraries using yo menu selection or command line argument
@jjwilliams42 jjwilliams42 mentioned this issue Mar 5, 2016
Merged
jjwilliams42 pushed a commit to jjwilliams42/generator-aspnet that referenced this issue Mar 5, 2016
Changes
5bb4742 
- Add semantic.validation.min.js for consistency
- Add tests for Semantic UI overrides per jjwilliams42/generator-aspnet-semanticui#9 and jjwilliams42/generator-aspnet-semanticui#6
- Add <% namespace %> to _Layout.cshtml (missing)
- Remove title from MenuLinkTagHelper rendering per jjwilliams42/generator-aspnet-semanticui#5
- Remove commented out code and extra call to $('.class').checkbox() in Login.cshtml
- Remove commented out code in various cshtml files
- Merged in functionality to use Semantic OR Bootstrap libraries using yo menu selection or command line argument
@jjwilliams42 jjwilliams42 mentioned this issue Mar 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterblazejewicz @jjwilliams42