Merge pull request sqlitebrowser#2275 from scottfurry/convert

Update to Windows Icon Generation script
jixuqianxing · Jun 7, 2020 · 044e484 · 044e484
2 parents fa04d72 + 90698e5
commit 044e484
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/iconwin.ico b/src/iconwin.ico
diff --git a/src/tools/create_windows_icon.sh b/src/tools/create_windows_icon.sh
@@ -2,11 +2,18 @@
 
 # This script depends on ImageMagick being installed
 
+FILES=()	# array accumulating names of converted images
+# commands to give to convert for each iteration
+MAGICK_CMDS="+antialias -units PixelsPerInch -alpha set -background transparent"
+SRC_FILE="../../images/logo.svg" # conversion source
+ICO_FILE="../iconwin.ico"        # ouput icon file
 for imgsize in 16 32 64 128
 do
-	convert ../../images/logo.svg -resize "$imgsize"x"$imgsize" -background transparent icon"$imgsize".png
-	files="$files icon$imgsize.png"
+    RESIZE="${imgsize}x${imgsize}"
+    DEST_FILE="icon${imgsize}.png"
+	# NOTE: explicitly not using quotes - outpput raw contents to convert command
+	convert ${MAGICK_CMDS} ${SRC_FILE} -resize ${RESIZE} ${DEST_FILE}
+    FILES+=("${DEST_FILE}")
 done
-
-convert $files ../iconwin.ico
-rm $files
+convert "${FILES[@]}" "${ICO_FILE}"
+rm "${FILES[@]}"