Remove printlns

jiujuan · Oct 1, 2021 · 94a4a41 · 94a4a41
1 parent 0dee700
commit 94a4a41
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/describegroups.go b/describegroups.go
@@ -131,12 +131,10 @@ func (c *Client) DescribeGroups(
 		}
 
 		for _, member := range apiGroup.Members {
-			fmt.Println("Decoding member metadata")
 			decodedMetadata, err := decodeMemberMetadata(member.MemberMetadata)
 			if err != nil {
 				return nil, err
 			}
-			fmt.Println("Decoding member assignments")
 			decodedAssignments, err := decodeMemberAssignments(member.MemberAssignment)
 			if err != nil {
 				return nil, err

diff --git a/reader_test.go b/reader_test.go
@@ -6,6 +6,7 @@ import (
 	"io"
 	"math/rand"
 	"net"
+	"os"
 	"reflect"
 	"strconv"
 	"sync"
@@ -571,6 +572,14 @@ func BenchmarkReader(b *testing.B) {
 }
 
 func TestCloseLeavesGroup(t *testing.T) {
+	if os.Getenv("KAFKA_VERSION") == "2.3.1" {
+		// There's a bug in 2.3.1 that causes the MemberMetadata to be in the wrong format and thus
+		// leads to an error when decoding the DescribeGroupsResponse.
+		//
+		// See https://issues.apache.org/jira/browse/KAFKA-9150 for details.
+		t.Skip("Skipping because kafka version is 2.3.1")
+	}
+
 	ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
 	defer cancel()