Fix strict mode syntax error #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Uncaught SyntaxError: In strict mode code, functions can only be declared at top level or immediately within another function."
|
How can we get this merged in? It is failing on iOS (Safari / Chrome). |
|
Thinking about that, the tooling (rollup) shouldn't be adding a "use strict" on top of this module, because it isn't intended to be run on a strict environment. It should add only for your own ES6 modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this error from an embedded STB version of Opera when including this library in a rollup bundle:
"Uncaught SyntaxError: In strict mode code, functions can only be declared at top level or immediately within another function."
It was preventing the entire bundle from being loaded... these changes satisfy the parser.