Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileLocalizedTypeRepository loads json file for every translation #39

Closed
florisrobbemont opened this issue Apr 12, 2013 · 2 comments
Closed

FileLocalizedTypeRepository loads json file for every translation #39

florisrobbemont opened this issue Apr 12, 2013 · 2 comments

Comments

@florisrobbemont
Copy link

In FileLocalizedTypeRepository.cs, the GetLanguage method, loads the entire JSON prompts file every time a translation is requested.

On line 242 in https://github.com/jgauffin/griffin.mvccontrib/blob/master/source/Griffin.MvcContrib/Localization/FlatFile/FileLocalizedTypeRepository.cs

Lines 241-246 can be replaced with:

prompts = LoadLanguage(culture) ?? new TypePromptCollection(culture);
_languages.Add(culture, prompts);
@paolosanchi
Copy link
Contributor

you are right, i'm going to commit your fix.

@paolosanchi
Copy link
Contributor

fixed paolosanchi@bb85f20 #41

mataprasad pushed a commit to mataprasad/localization that referenced this issue Jan 29, 2017
@paolosanchi
Bugfix: jgauffin/griffin.mvccontrib#39
bb85f20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgauffin @paolosanchi @florisrobbemont