Rephrasing no errors found message (#632)

jfrog · Mar 4, 2024 · 8a702e2 · 8a702e2
1 parent 438e442
commit 8a702e2
Show file tree

Hide file tree

Showing 15 changed files with 17 additions and 17 deletions.
diff --git a/resources/v2/noVulnerabilityBannerMR.png b/resources/v2/noVulnerabilityBannerMR.png
diff --git a/resources/v2/noVulnerabilityBannerPR.png b/resources/v2/noVulnerabilityBannerPR.png
diff --git a/...data/messages/summarycomment/structure/summary_comment_no_issues_mr_entitled.md b/...data/messages/summarycomment/structure/summary_comment_no_issues_mr_entitled.md
@@ -1,6 +1,6 @@
 <div align='center'>
 
-[![👍 Frogbot scanned this merge request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
+[![👍 Frogbot scanned this merge request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
 
 </div>
 

diff --git a/.../messages/summarycomment/structure/summary_comment_no_issues_mr_not_entitled.md b/.../messages/summarycomment/structure/summary_comment_no_issues_mr_not_entitled.md
@@ -1,6 +1,6 @@
 <div align='center'>
 
-[![👍 Frogbot scanned this merge request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
+[![👍 Frogbot scanned this merge request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
 
 </div>
 

diff --git a/...data/messages/summarycomment/structure/summary_comment_no_issues_pr_entitled.md b/...data/messages/summarycomment/structure/summary_comment_no_issues_pr_entitled.md
@@ -1,6 +1,6 @@
 <div align='center'>
 
-[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
+[![👍 Frogbot scanned this pull request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
 
 </div>
 

diff --git a/...es/summarycomment/structure/summary_comment_no_issues_pr_entitled_with_title.md b/...es/summarycomment/structure/summary_comment_no_issues_pr_entitled_with_title.md
@@ -1,6 +1,6 @@
 <div align='center'>
 
-[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
+[![👍 Frogbot scanned this pull request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
 
 </div>
 

diff --git a/.../messages/summarycomment/structure/summary_comment_no_issues_pr_not_entitled.md b/.../messages/summarycomment/structure/summary_comment_no_issues_pr_not_entitled.md
@@ -1,6 +1,6 @@
 <div align='center'>
 
-[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
+[![👍 Frogbot scanned this pull request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
 
 </div>
 

diff --git a/...ummarycomment/structure/summary_comment_no_issues_pr_not_entitled_with_title.md b/...ummarycomment/structure/summary_comment_no_issues_pr_not_entitled_with_title.md
@@ -1,6 +1,6 @@
 <div align='center'>
 
-[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
+[![👍 Frogbot scanned this pull request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
 
 </div>
 

diff --git a/...sages/summarycomment/structure/summary_comment_no_issues_simplified_entitled.md b/...sages/summarycomment/structure/summary_comment_no_issues_simplified_entitled.md
@@ -1,4 +1,4 @@
-**👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.**
+**👍 Frogbot scanned this pull request and did not find any new security issues.**
 
 
 ---

diff --git a/...s/summarycomment/structure/summary_comment_no_issues_simplified_not_entitled.md b/...s/summarycomment/structure/summary_comment_no_issues_simplified_not_entitled.md
@@ -1,4 +1,4 @@
-**👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.**
+**👍 Frogbot scanned this pull request and did not find any new security issues.**
 
 ---
 Note:

diff --git a/...mment/structure/summary_comment_no_issues_simplified_not_entitled_with_title.md b/...mment/structure/summary_comment_no_issues_simplified_not_entitled_with_title.md
@@ -1,4 +1,4 @@
-**👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.**
+**👍 Frogbot scanned this pull request and did not find any new security issues.**
 
 ---
 ## **Custom title**

diff --git a/utils/outputwriter/icons.go b/utils/outputwriter/icons.go
@@ -75,13 +75,13 @@ func GetIconTag(imageSource ImageSource) string {
 func GetSimplifiedTitle(is ImageSource) string {
 	switch is {
 	case NoVulnerabilityPrBannerSource:
-		return "👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies."
+		return "👍 Frogbot scanned this pull request and did not find any new security issues."
 	case VulnerabilitiesPrBannerSource:
 		return "🚨 Frogbot scanned this pull request and found the below:"
 	case VulnerabilitiesFixPrBannerSource:
 		return "🚨 This automated pull request was created by Frogbot and fixes the below:"
 	case NoVulnerabilityMrBannerSource:
-		return "👍 Frogbot scanned this merge request and found that it did not add vulnerable dependencies."
+		return "👍 Frogbot scanned this merge request and did not find any new security issues."
 	case VulnerabilitiesMrBannerSource:
 		return "🚨 Frogbot scanned this merge request and found the below:"
 	case VulnerabilitiesFixMrBannerSource:

diff --git a/utils/outputwriter/icons_test.go b/utils/outputwriter/icons_test.go
@@ -23,16 +23,16 @@ func TestGetSeverityTagNotApplicable(t *testing.T) {
 }
 
 func TestGetVulnerabilitiesBanners(t *testing.T) {
-	assert.Equal(t, "<div align='center'>\n\n[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n", GetBanner(NoVulnerabilityPrBannerSource))
-	assert.Equal(t, "<div align='center'>\n\n[![👍 Frogbot scanned this merge request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n", GetBanner(NoVulnerabilityMrBannerSource))
+	assert.Equal(t, "<div align='center'>\n\n[![👍 Frogbot scanned this pull request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n", GetBanner(NoVulnerabilityPrBannerSource))
+	assert.Equal(t, "<div align='center'>\n\n[![👍 Frogbot scanned this merge request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n", GetBanner(NoVulnerabilityMrBannerSource))
 	assert.Equal(t, "<div align='center'>\n\n[![🚨 Frogbot scanned this pull request and found the below:](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/vulnerabilitiesBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n", GetBanner(VulnerabilitiesPrBannerSource))
 	assert.Equal(t, "<div align='center'>\n\n[![🚨 Frogbot scanned this merge request and found the below:](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/vulnerabilitiesBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n", GetBanner(VulnerabilitiesMrBannerSource))
 	assert.Equal(t, "<div align='center'>\n\n[![🚨 This automated pull request was created by Frogbot and fixes the below:](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/vulnerabilitiesFixBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n", GetBanner(VulnerabilitiesFixPrBannerSource))
 	assert.Equal(t, "<div align='center'>\n\n[![🚨 This automated merge request was created by Frogbot and fixes the below:](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/vulnerabilitiesFixBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n", GetBanner(VulnerabilitiesFixMrBannerSource))
 }
 
 func TestGetSimplifiedTitle(t *testing.T) {
-	assert.Equal(t, "👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.", GetSimplifiedTitle(NoVulnerabilityPrBannerSource))
+	assert.Equal(t, "👍 Frogbot scanned this pull request and did not find any new security issues.", GetSimplifiedTitle(NoVulnerabilityPrBannerSource))
 	assert.Equal(t, "🚨 Frogbot scanned this pull request and found the below:", GetSimplifiedTitle(VulnerabilitiesPrBannerSource))
 	assert.Equal(t, "🚨 This automated pull request was created by Frogbot and fixes the below:", GetSimplifiedTitle(VulnerabilitiesFixPrBannerSource))
 	assert.Equal(t, "", GetSimplifiedTitle("none"))

diff --git a/utils/outputwriter/simplifiedoutput_test.go b/utils/outputwriter/simplifiedoutput_test.go
@@ -71,7 +71,7 @@ func TestSimpleImage(t *testing.T) {
 		{
 			name:           "no vulnerability pr banner",
 			source:         NoVulnerabilityPrBannerSource,
-			expectedOutput: "**👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.**",
+			expectedOutput: "**👍 Frogbot scanned this pull request and did not find any new security issues.**",
 		},
 		{
 			name:           "vulnerabilities pr banner",

diff --git a/utils/outputwriter/standardoutput_test.go b/utils/outputwriter/standardoutput_test.go
@@ -87,7 +87,7 @@ func TestStandardImage(t *testing.T) {
 		{
 			name:           "no vulnerability pr banner",
 			source:         NoVulnerabilityPrBannerSource,
-			expectedOutput: "<div align='center'>\n\n[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n",
+			expectedOutput: "<div align='center'>\n\n[![👍 Frogbot scanned this pull request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n",
 		},
 		{
 			name:           "vulnerabilities pr banner",
@@ -97,7 +97,7 @@ func TestStandardImage(t *testing.T) {
 		{
 			name:           "no vulnerability mr banner",
 			source:         NoVulnerabilityMrBannerSource,
-			expectedOutput: "<div align='center'>\n\n[![👍 Frogbot scanned this merge request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n",
+			expectedOutput: "<div align='center'>\n\n[![👍 Frogbot scanned this merge request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerMR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)\n\n</div>\n",
 		},
 		{
 			name:           "vulnerabilities mr banner",