-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flakes] generate flake.nix file for php-related packages #639
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
b0872da
to
324d480
Compare
cd1d62c
to
3df1cb5
Compare
324d480
to
519dd92
Compare
c7940f0
to
7e22dff
Compare
3df1cb5
to
1d4a3b0
Compare
7e22dff
to
a92a7aa
Compare
a92a7aa
to
903ea67
Compare
@savil I think this PR might not be necessary if we solve a flakes bug detailed here: #655 #648 might similarly not be needed. the tldr is that we should not add the profile path when starting shell (or if we do we need a way to control the binaries there to ensure they represent the flake.nix ones and not the individually installed ones). |
@savil I'm going to remove myself as a reviewer since I think you and Mike are going to figure out the best way to tackle this. Feel free to re-add me if you still need a review. |
We are going to simplify this to just the flake.nix changes. Separately, @mikeland86 will remove nix-profile from PATH and we can then directly do print-dev-env on this flake.nix file. |
ec2f9f8
to
0c15f9c
Compare
Summary
For
flake.nix
:buildInputs
list so that it uses thephp
packages fromDefinitions
instead of fromnixpkgs
(if Definitions exist)TODO for future PR:
buildInputs
should bepackages
inflake.nix
How was it tested?
in
examples/testdata/php/php-extensions
, starteddevbox shell
withDEVBOX_FEATURE_FLAKES=0
andDEVBOX_FEATURE_FLAKES=1
. Inspected the generatedflake.nix
files.