Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugins] Use reflikes for plugins #1845

Merged
merged 24 commits into from
Feb 29, 2024
Merged

[plugins] Use reflikes for plugins #1845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1ef5d29
[plugins] Unify plugin config and devbox config
mikeland73 Feb 22, 2024
6386016
Update readme -> description
mikeland73 Feb 22, 2024
8fa019e
Fix tests
mikeland73 Feb 22, 2024
b98ab45
Update lockfile
mikeland73 Feb 22, 2024
511bcbb
Bump timout
mikeland73 Feb 22, 2024
e67d8e6
Bump timout to 10s
mikeland73 Feb 22, 2024
1239bcc
Revert
mikeland73 Feb 23, 2024
b7eec16
Change port for lapp
mikeland73 Feb 23, 2024
100a77f
Revert "Change port for lapp"
mikeland73 Feb 23, 2024
8866689
Merge branch 'main' into landau/plugins-unify
mikeland73 Feb 23, 2024
d8bb837
Merge branch 'main' into landau/plugins-unify
mikeland73 Feb 23, 2024
f8404d9
Merge branch 'main' into landau/plugins-unify
mikeland73 Feb 26, 2024
a7d0dbe
Fix
mikeland73 Feb 26, 2024
5e804f2
Merge branch 'main' into landau/plugins-unify
mikeland73 Feb 26, 2024
275fd49
[plugins] Use reflikes for plugins
mikeland73 Feb 26, 2024
dd716a7
Fix lint issue
mikeland73 Feb 26, 2024
8aaec6b
fix builtins
mikeland73 Feb 26, 2024
908f9a8
Merge branch 'main' into landau/shift-plugins-to-config
mikeland73 Feb 28, 2024
8f7d329
Merge branch 'main' into landau/shift-plugins-to-config
mikeland73 Feb 28, 2024
1bf645a
Use cmp.Or
mikeland73 Feb 28, 2024
3261194
Requested changes, add test
mikeland73 Feb 28, 2024
cfa1b15
More testability
mikeland73 Feb 29, 2024
8a6f071
Merge branch 'main' into landau/shift-plugins-to-config
mikeland73 Feb 29, 2024
c4c31c2
Fix test
mikeland73 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint issue
  • Loading branch information
@mikeland73
mikeland73 committed Feb 26, 2024
commit dd716a77953a234e85aee707ac5c1044914e9504
4 changes: 2 additions & 2 deletions internal/plugin/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ type githubPlugin struct {
RefLike
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of embedding the struct, could we make it an explicit field to distinguish methods/fields that are from RefLike versus native to githubPlugin?

But its tolerable if it means having to re-implement a lot of methods unnecessarily

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make that change. It does mean that plugin.Repo becomes plugin.ref.Repo so the code is a big uglier. (There's roughly 12 callsites in this file that would change)

}

func newGithubPlugin(ref RefLike) (*githubPlugin, error) {
func newGithubPlugin(ref RefLike) *githubPlugin {
if ref.Ref.Ref == "" && ref.Rev == "" {
ref.Ref.Ref = "master"
}
return &githubPlugin{RefLike: ref}, nil
return &githubPlugin{RefLike: ref}
}

func (p *githubPlugin) Fetch() ([]byte, error) {
Expand Down
2 changes: 1 addition & 1 deletion internal/plugin/reflike.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func Parse(s string) (Includable, error) {
case flake.TypePath:
return newLocalPlugin(reflike)
case flake.TypeGitHub:
return newGithubPlugin(reflike)
return newGithubPlugin(reflike), nil
default:
return nil, fmt.Errorf("unsupported ref type %q", ref.Type)
}
Expand Down