perf: Fold should accept an array of events #409
Conversation
| @@ -75,7 +75,7 @@ type private Category<'event, 'state, 'context, 'Format>(store: VolatileStore<'F | |||
| member _.Load(_log, _categoryName, _streamId, streamName, _maxAge, _requireLeader, _ct) = | |||
| match store.Load(streamName) with | |||
| | null -> struct (Token.ofEmpty, initial) |> Task.FromResult | |||
| | xs -> struct (Token.ofValue xs, fold initial (Seq.chooseV codec.TryDecode xs)) |> Task.FromResult | |||
| | xs -> struct (Token.ofValue xs, fold initial (Array.chooseV codec.TryDecode xs)) |> Task.FromResult | |||
There was a problem hiding this comment.
this one is ok but its an example of the waste there can be
| @@ -81,12 +81,12 @@ let verifyCorrectEventGenerationWhenAppropriate command (originState: State) = | |||
| /// (and hence potentially-conflicting) changes | |||
| let verifyIdempotency (cmd: Command) (originState: State) = | |||
| // Put the aggregate into the state where the command should not trigger an event | |||
| let establish: Events.Event list = cmd |> function | |||
| | AddItem (_, skuId, qty, waive) -> [ mkAddQty skuId qty waive] | |||
| let establish: Events.Event[] = cmd |> function | |||
There was a problem hiding this comment.
can become an array comprehension given V6 not requiring yield
| let state = fold originState initialEvents | ||
| let events = interpret command state | ||
| let state' = fold state events | ||
| let state' = fold state (Seq.toArray events) |
There was a problem hiding this comment.
this would be bad. But make the decide fn return arrays and see if its ok
| ?load, ?attempts): Async<'view> = Async.call <| fun ct -> | ||
| let inline decide' c ct = task { let! r, es = Async.StartImmediateAsTask(decide c, ct) in return struct (r, Seq.ofList es) } | ||
| let inline decide' c ct = task { let! r, es = Async.StartImmediateAsTask(decide c, ct) in return struct (r, es) } |
There was a problem hiding this comment.
hm tempting to require struct tuple results - then no task expr would be required
There was a problem hiding this comment.
One thing at at time?
There was a problem hiding this comment.
I guess so. But the non-struct tuples is the only/key remaining wart vs DeciderCore
And if there is going to be an open Equinox.V3Interop, then it can map from non-struct tuples to struct ones...
But you're probably correct too
| @@ -38,8 +38,8 @@ type Command = | |||
| let interpret command (state: Fold.State) = | |||
| match command with | |||
| | Update ({ preferences = preferences } as value) -> | |||
| if state = preferences then [] else | |||
| [ Events.Updated value ] | |||
| if state = preferences then [||] else | |||
There was a problem hiding this comment.
[| if state <> preferences then Events.Updated value |]
| yield Events.Favorited { date = date; skuId = skuId } ] | ||
| [| for skuId in Seq.distinct skuIds do | ||
| if state |> doesntHave skuId then | ||
| yield Events.Favorited { date = date; skuId = skuId } |] |
| if state |> doesntHave skuId then [] else | ||
| [ Events.Unfavorited { skuId = skuId } ] | ||
| if state |> doesntHave skuId then [||] else | ||
| [| Events.Unfavorited { skuId = skuId } |] |
There was a problem hiding this comment.
wrap whole thing as a array comprehension
| if state = preferences then [||] else | ||
| [| Events.Updated value |] |
There was a problem hiding this comment.
| if state = preferences then [||] else | |
| [| Events.Updated value |] | |
| [| if state <> preferences then Events.Updated value |] |
| match command with | ||
| // a request to set quantity of `0` represents a removal request | ||
| | SyncItem (Context c, skuId, Some 0, _) -> | ||
| if itemExistsWithSkuId skuId then [ Events.ItemRemoved { context = c; skuId = skuId } ] | ||
| else [] | ||
| if itemExistsWithSkuId skuId then [| Events.ItemRemoved { context = c; skuId = skuId } |] |
There was a problem hiding this comment.
same stuff here, either individual cases of the match, or maybe the whole thing should
wrap whole thing as a array comprehension
otherwise the noise is a bit much with that forest of hard to type symbols
| | Merge items, Choice1Of2 randomSkus -> mkAppend randomSkus @ mkMerged items | ||
| | Merge (TakeHalf items), Choice2Of2 randomSkus -> mkAppend randomSkus @ mkMerged items | ||
| | Add (d,TakeHalf skus), Choice2Of2 moreSkus -> Array.append <| mkAppendDated d skus <| mkAppendDated (let n = DateTimeOffset.Now in n.AddDays -1.) moreSkus | ||
| | Merge items, Choice1Of2 randomSkus -> Array.append <| mkAppend randomSkus <| mkMerged items |
There was a problem hiding this comment.
array comprehension with yield!
And you know better than to do do <| !
|
Superseded by #411 - thanks for paving the way for this excellent simplification to the (new) user experience |
No description provided.