Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BatcherCache, BatcherDictionary #390

Merged
merged 10 commits into from
Jun 6, 2023
Merged

Add BatcherCache, BatcherDictionary #390

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
660d5fd
Align AsyncBatchingGate with CacheCell
bartelink Jun 5, 2023
ca3418a
Tidy
bartelink Jun 5, 2023
884f24e
Fix names
bartelink Jun 5, 2023
c651b29
Revise cache timings
bartelink Jun 6, 2023
d9ca64b
Expose inner Cache, hide Load/Save
bartelink Jun 6, 2023
ecad52b
ABG comments
bartelink Jun 6, 2023
9846b32
Add Async.call
bartelink Jun 6, 2023
4e5a7ee
Add BatcherCache, BatcherDictionary
bartelink Jun 6, 2023
0d7a9c2
Changelog
bartelink Jun 6, 2023
e211121
More tolerance, smh...
bartelink Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ABG comments
  • Loading branch information
@bartelink
bartelink committed Jun 6, 2023
commit ecad52b5120a253be68b7327ae55f811c06dbe73
4 changes: 2 additions & 2 deletions src/Equinox.Core/AsyncBatchingGate.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ type AsyncBatchingGate<'Req, 'Res>(dispatch: Func<'Req[], CancellationToken, Tas
// If current has not yet been dispatched, hop on and join
if current.TryAdd(req, dispatch, lingerMs, ct) then return! current.Await()
else // Any thread that discovers a batch in flight, needs to wait for it to conclude first
do! current.Await().ContinueWith<unit>(fun (_: Task) -> ()) // don't observe the exception or result from the in-flight batch
do! current.Await().ContinueWith<unit>(fun (_: Task) -> ()) // wait for, but don't observe the exception or result from the in-flight batch
// where competing threads discover a closed flight, we only want a single one to regenerate it
let _ = Interlocked.CompareExchange(&cell, AsyncBatch(), current)
return! x.ExecuteAsync(req, ct) }
return! x.ExecuteAsync(req, ct) } // but everyone attempts to merge their requests into the batch during the linger period

/// Include an item in the batch; await the collective dispatch (subject to the configured linger time)
member x.Execute(req) = async {
Expand Down