Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optionality from Cosmos caching #107

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Conversation

bartelink
Copy link
Collaborator

Adds friction per #104 to the CosmosResolver API to ensure people have to go out of their way to avoid caching

@bartelink bartelink requested a review from jakzale March 4, 2019 20:52
@bartelink bartelink force-pushed the caching-explicit-optout branch from bed57b5 to f468420 Compare March 4, 2019 20:54
@bartelink
Copy link
Collaborator Author

@jakzale Any wording improvements or other suggestions appreciated

@bartelink bartelink marked this pull request as ready for review March 4, 2019 22:54
Copy link

@jakzale jakzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartelink bartelink force-pushed the caching-explicit-optout branch from 27ccd9b to cac6139 Compare March 5, 2019 12:52
@bartelink bartelink force-pushed the caching-explicit-optout branch from cac6139 to 2316b3b Compare March 5, 2019 12:55
@bartelink bartelink merged commit 365f8ef into master Mar 5, 2019
@bartelink bartelink deleted the caching-explicit-optout branch March 5, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants