Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing test coverage for null Data across all stores #210

Closed
bartelink opened this issue Mar 25, 2020 · 2 comments
Closed

Missing test coverage for null Data across all stores #210

bartelink opened this issue Mar 25, 2020 · 2 comments
Labels
good-first-issue up-for-grabs https://up-for-grabs.net

Comments

@bartelink
Copy link
Collaborator

As a follow-up to #209, which fixes this bug for SqlStreamStore (the presence of the bug has its roots in #175)

There's a lack of coverage of the writing an event with a null content for the Data field

I believe Equinox.Cosmos has coverage, but the SqlStreamStore + EventStore integration tests do not cover it.

Fix is to include a test scenario that generates an Event union with no body
@bartelink
Copy link
Collaborator Author

Per chat in DDD-CQRS-ES slack, EventStore's GRPC client will likely also begin to reject Data that's null in due course

@bartelink
Copy link
Collaborator Author

Resolved indirectly by #323 - using ReadOnlyMemory<byte> ends up less error prone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue up-for-grabs https://up-for-grabs.net
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartelink