Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new V8 api #50

Merged
merged 38 commits into from
Feb 6, 2019
Merged

Upgrade to new V8 api #50

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
eb637d5
Port to new v8 api
jeroen Jan 30, 2019
324cc53
Backup wip
jeroen Jan 30, 2019
9ce3c95
Fix context
jeroen Jan 30, 2019
a282f1d
More fixes
jeroen Jan 30, 2019
acdcb33
Fix unit test
jeroen Jan 30, 2019
4ccec96
Bump
jeroen Feb 2, 2019
00dcf5a
Special case Debian for now
jeroen Feb 2, 2019
72baa61
Move include to keep types same as legacy
jeroen Feb 2, 2019
62ed60a
Add back support for legacy V8
jeroen Feb 3, 2019
9ed0cda
Hint ICU
jeroen Feb 3, 2019
70713f2
Fix legacy
jeroen Feb 3, 2019
7d8a550
Fix
jeroen Feb 3, 2019
ad49815
Move init call
jeroen Feb 4, 2019
f35ea24
Fix compiler warning
jeroen Feb 4, 2019
2f3d4db
Add onAttach message
jeroen Feb 4, 2019
1e88348
Update Travis
jeroen Feb 4, 2019
79d58a3
Tweak test for Debian libnode-dev
jeroen Feb 4, 2019
60c7c7f
Tweak test
jeroen Feb 4, 2019
69fc9dd
Fix code for V8 6.2
jeroen Feb 4, 2019
7f8eb71
More 6.2 fixes
jeroen Feb 4, 2019
dc1c7d7
Fix Windows / MacOS legacy builds
jeroen Feb 5, 2019
f575b6f
Windows: update libv8
jeroen Feb 5, 2019
e09d596
Fix autobrew
jeroen Feb 5, 2019
d77c72f
Fixes for V8 version 7
jeroen Feb 5, 2019
efba8e8
Factor out template
jeroen Feb 5, 2019
650324b
Wording
jeroen Feb 5, 2019
10060f9
Update docs
jeroen Feb 5, 2019
2ca0159
Make namespace explicit
jeroen Feb 5, 2019
ef042c0
Try to fix Fedora: unset window.console before setting
jeroen Feb 5, 2019
6317f63
Comments
jeroen Feb 5, 2019
d0859ff
Formatting
jeroen Feb 5, 2019
e405e53
Fix print function
jeroen Feb 5, 2019
bd38ab8
Recommend recent v8 on Fedora
jeroen Feb 6, 2019
663c775
Update readme
jeroen Feb 6, 2019
bc681c0
More readme
jeroen Feb 6, 2019
6011919
Temp fix
jeroen Feb 6, 2019
2307d6f
MacOS: upgrade v8 bottle
jeroen Feb 6, 2019
61f56e1
Fix for Homebrew V8: initiate bundled ICU data
jeroen Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Temp fix
  • Loading branch information
@jeroen
jeroen committed Feb 6, 2019
commit 6011919df0addd331db8f01f6b749d572a4a95e0
2 changes: 1 addition & 1 deletion tools/winlibs.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ VERSION <- commandArgs(TRUE)
LIBDIR <- paste0("../windows/libv8-", VERSION)
if(!file.exists(paste0(LIBDIR, "/include/v8.h"))){
if(getRversion() < "3.3.0") stop("This library requires R 3.3 or newer")
download.file(sprintf("https://github.com/rwinlib/libv8/archive/v%s.zip", VERSION), "v8.zip", quiet = TRUE)
download.file(sprintf("https://github.com/rwinlib/libv8/archive/v%s.zip", VERSION), "v8.zip", quiet = TRUE, method = 'libcurl')
dir.create("../windows", showWarnings = FALSE)
unzip("v8.zip", exdir = "../windows")
setwd(LIBDIR)
Expand Down