Fix broken symlink traversal issue #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 12, 2018 01:45
- Fallback to fs.lstat if fails (fs.stat fails for broken symlinks
cause it looks up for original target, wherease fs.lstat only
returns stat for the symlink file instead of looking up original)
- For broken symlinks stats might be undefined and in other cases
isSymbolicLink is available instead of isDirectory
- Broken symlink will be added to files list as expected
|
@jergason can you please take a look and let know what do you think? |
jrtechs
approved these changes
Feb 3, 2019
There was a problem hiding this comment.
@dibosh Looks great! I came across a similar issue and developed a solution before realizing that you beet me too it 😄 I approve these changes however, it looks like the maintainer @jergason is not active? I guess that is why there are so many forks.
|
@jrtechs haha! You are right- I wish there was one more maintainer and it was merged into the original one, am sure the more people will use it, the more they will end up in such cases. |
|
@jergason nudge after another couple years! Can this be merged? Or is it fixed already in any of the latest release? I would be happy to close it if it's not relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue #42 is pretty frequent in MacOSX and this is another stab at fixing the issue.
Has similar
lstatapproach as first appeared in #51, but addresses the problem without replacing/editing much code and keeping a minimal footprint yet similar signature in a refactored method.Also, the expected behaviour for a broken symlink should be- if it was not possible to dive into it, then don't do it but add it to returned file list(instead of expecting some sort of check in provided
ignores). Which is the exact behaviour in this PR.