-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return files even if an error occurred #43
Conversation
Does my pull request is ok for you ? would you like to merge it ? |
When will this change be released? |
I use this code since 1 month and it works great.. |
please merge.. |
I have similar concerns with this PR as with #35: ignoring every single error feels wrong to me. If the goal is to continue on broken symbolic links, is there a way to specifically check if the error is for a broken symbolic link, and only continue in that case? |
I think that the feature we want is that recursive-readdir return files that are "ok" in all case. Then, by setting option I you want just correct the symlink error, I think you should add a test to know if the current file is a symlink and if the error code is "ENOENT". I could do an other PR later for this if you want.. |
@jergason this feature fit the needs of @kevincaradant and many others ! I think you should merge it in your repo ??? |
@popod I'm happy to revisit this if you handle the objection I specified: continuing on only |
@jergason why only for As I tell you in my last message, I should add another option to handle the Ok for you ? |
Add an option to allow returning files even if a fs.stat error occurs.
#42 #35