chore: Refactor for pr.go cmd #103
Conversation
|
Hi @GavinPJK. Thanks for your PR. I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @msvticket |
|
| if rule.ReusePullRequest { | ||
| if len(o.Labels) == 0 { | ||
| return fmt.Errorf("to be able to reuse pull request you need to supply pullRequestLabels in config file or --labels") | ||
| } | ||
| o.PullRequestFilter = &environments.PullRequestFilter{Labels: []string{}} | ||
| for _, label := range o.Labels { | ||
| o.PullRequestFilter.Labels = stringhelpers.EnsureStringArrayContains(o.PullRequestFilter.Labels, label) | ||
| } | ||
| if o.AutoMerge { | ||
| o.PullRequestFilter.Labels = stringhelpers.EnsureStringArrayContains(o.PullRequestFilter.Labels, environments.LabelUpdatebot) | ||
| } | ||
| } |
There was a problem hiding this comment.
By removing this code you remove the functionality of reusing an existing open pull request. Please add it back.
|
Not that it matters that much, but https://www.conventionalcommits.org/ (and our code) defines the distinct commit type |
As suggested by @msvticket, refactor code for
cmd/pr/pr.gobefore introducing additional features.