Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag support to list view #6020

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Add tag support to list view #6020

merged 3 commits into from
Sep 8, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Adds tag support to the list view
  • Replaces the search link for tags with the list view link

Issues
N/A

@thornbill thornbill added the feature New feature or request label Sep 4, 2024
@thornbill thornbill added this to the v10.10.0 milestone Sep 4, 2024
@thornbill thornbill requested a review from a team as a code owner September 4, 2024 12:41
@viown
Copy link
Member

viown commented Sep 4, 2024

jellyfin-web/src/controllers/list.js

Line 1211 in d01cfa4

} else if (params.type === 'Programs' || params.type === 'Recordings' || params.type === 'Person' || params.type === 'nextup' || params.type === 'Audio' || params.type === 'MusicAlbum' || params.type === 'MusicArtist') {

Maybe we can add params.tag here so the title and year are displayed.

@thornbill
Copy link
Member Author

Thanks for the feedback @viown! I made some adjustments to add tag as the type as I noticed the default sort order was also weird without specifying a type.

grafixeyehero
grafixeyehero reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@grafixeyehero grafixeyehero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit ce182d286b934cdf6ce26d1818f2c5eac2220b80
Status ✅ Deployed!
Preview URL https://60de7e36.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit ee29a98 into jellyfin:master Sep 8, 2024
12 checks passed
@thornbill thornbill deleted the tag-list-view branch September 8, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafixeyehero grafixeyehero grafixeyehero approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thornbill @viown @jellyfin-bot @grafixeyehero