Fix pattern selector.

More cleanup.
jclark2019 · Feb 12, 2022 · 53a27f4 · 53a27f4
1 parent 7858d46
commit 53a27f4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/index.htm b/index.htm
@@ -465,7 +465,7 @@ <h6 class="mb-2 text-muted">
         <div class="input-group">
           <div class="input-group-text">Pattern</div>
           <select id="selectPattern" class="form-control w-auto">
-            <option selected>palette</option>
+            <option selected>physical order</option>
             <option>clockwise palette</option>
             <option>counter-clockwise palette</option>
             <option>outward palette</option>

diff --git a/index.js b/index.js
@@ -75,15 +75,11 @@ context.textAlign = "center";
 context.textBaseline = "middle";
 context.font = "1px monospace";
 
-// define some global variables
-let width, height, rows, leds;
-
-let minX, minY;
-let maxX, maxY;
+// define some global variables (working on eliminating these)
+let width, height, rows, leds, maxX, maxY, minX, minY, coordsX, coordsY, angles, radii;
 
 let offset = 0;
 let offsetIncrement = 1.0;
-let coordsX, coordsY, angles, radii;
 
 let running = true;
 let showPreviewBorders = true;
@@ -198,7 +194,7 @@ function onPaletteChange() {
 }
 
 function onPatternChange() {
-  const code = getPatternCode(selectPalette.value);
+  const code = getPatternCode(selectPattern.value);
   inputPreviewCode.value = code;
   onPreviewCodeChange();
   if (!running) window.requestAnimationFrame(render);
@@ -271,7 +267,6 @@ function onTextLayoutChange() {
 }
 
 function onWindowResize() {
-  // const min = Math.min(window.innerWidth, window.innerHeight) - 48;
   const min = window.innerWidth - 48;
 
   canvasPreview.width = min;
@@ -374,6 +369,7 @@ function parsePixelblaze() {
   ({ height, leds, maxX, maxY, minX, minY, rows, width } = results);
 
   document.getElementById("codeParsedPixelblaze").innerText = JSON.stringify(rows);
+
   inputWidth.value = width;
   inputHeight.value = height;
   inputCenterX.value = width / 2;

diff --git a/js/patterns.js b/js/patterns.js
@@ -1,6 +1,6 @@
 export function getPatternCode(patternName) {
-  switch (selectPattern.value) {
-    case "palette":
+  switch (patternName) {
+    case "physical order":
       return "return ColorFromPalette(currentPalette, i - offset);";
     case "clockwise palette":
       return "return ColorFromPalette(currentPalette, angles[i] - offset);";