Skip to content

Commit

Permalink
sdk: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archives
Browse files Browse the repository at this point in the history
Using these config-options to customize the folders used at build-time makes these
folder settings appear in generated archive. This causes the SDK to be not
portable, as it's going to use the build-time folders on the new systems.
The errors vary from passing the build, disk out-of-space to permission denied.

The build-time settings of these folders are passed into the archive via Config.build.
The expected behavior is that the SDK acts after unpacking like these settings have
their defaults, using intree folders. So just filter these folders out when running
convert-config.pl to create Config.build.

This addresses the same issue that's fixed in the previous commit for the imagebuilder.

Signed-off-by: Sven Roederer <devel-sven@geroedel.de>
  • Loading branch information
SvenRoederer authored and Baptiste Jonglez committed May 8, 2021
1 parent 6967903 commit 1e4b191
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion target/sdk/convert-config.pl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@
chomp;
next if /^CONFIG_SIGNED_PACKAGES/;

if (/^CONFIG_([^=]+)=(.*)$/) {
if (/^CONFIG_((BINARY)|(DOWNLOAD))_FOLDER=(.*)$/) {
# We don't want to preserve the build setting of
# BINARY_FOLDER and DOWNLOAD_FOLDER.
$var = "$1_FOLDER";
$val = '""';
$type = "string";
} elsif (/^CONFIG_([^=]+)=(.*)$/) {
$var = $1;
$val = $2;

Expand Down

0 comments on commit 1e4b191

Please sign in to comment.