Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1179 - isValid returns true in the absence of validate. #1181

Merged
merged 1 commit into from
Apr 4, 2012
Merged

Fix #1179 - isValid returns true in the absence of validate. #1181

merged 1 commit into from
Apr 4, 2012

Conversation

braddunbar
Copy link
Collaborator

As stated in #1179, _validate returns true in the absence of validate. This suggests that models without validate are valid models and that isValid should return true instead of throwing a TypeError.

@jashkenas
Copy link
Owner

Lovely.

jashkenas added a commit that referenced this pull request Apr 4, 2012
@jashkenas
Merge pull request #1181 from braddunbar/isvalid
091b3e5 
Fix #1179 - isValid returns true in the absence of validate.
@jashkenas jashkenas merged commit 091b3e5 into jashkenas:master Apr 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braddunbar @jashkenas