[deps]: Upgrade redux and react-redux to latest version #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 255 255
Lines 7738 7738
Branches 1937 2004 +67
=======================================
Hits 7476 7476
Misses 262 262 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
string. According to them, this change is to make the action obj serializable. Change log: https://redux.js.org/usage/migrations/migrating-rtk-2#action-types-must-be-stringsrequireActualinjest.mock, it would anyway be the actual implementation of functions for other test cases.How was this change tested?
npm run startis working fineHow was this upgrade carried out?
npm uninstall react-redux -w packages/jaeger-uito removereact-reduxnpm uninstall redux -w packages/jaeger-uito removereduxnpm install react-redux -w packages/jaeger-uito install react-redux latest version. This installed the latest version but the package was nested in jaeger-ui node modules so had to do step 4.npm install redux -w packages/jaeger-ui. This worked.npm uninstall react-redux -w packages/jaeger-uito removereact-reduxnested entry in lockfilenpm install react-redux -w packages/jaeger-uito install react-redux latest version. This finally created an entry in root node_modules in lockfile.Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test