Remove extra semis in RN (facebook#38068)

Summary: X-link: facebook/hermes#1037 Pull Request resolved: facebook#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: 6111e85411e385d2aef9d7407e9b2bfc0011e786
itsjohnward · Jun 26, 2023 · 5577b9c · 5577b9c
1 parent e1fd4a8
commit 5577b9c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/packages/react-native/ReactCommon/jsi/jsi/jsi.h b/packages/react-native/ReactCommon/jsi/jsi/jsi.h
@@ -1389,7 +1389,7 @@ class JSI_EXPORT Scope {
   explicit Scope(Runtime& rt) : rt_(rt), prv_(rt.pushScope()) {}
   ~Scope() {
     rt_.popScope(prv_);
-  };
+  }
 
   Scope(const Scope&) = delete;
   Scope(Scope&&) = delete;
@@ -1411,8 +1411,8 @@ class JSI_EXPORT Scope {
 /// Base class for jsi exceptions
 class JSI_EXPORT JSIException : public std::exception {
  protected:
-  JSIException(){};
-  JSIException(std::string what) : what_(std::move(what)){};
+  JSIException() {}
+  JSIException(std::string what) : what_(std::move(what)) {}
 
  public:
   JSIException(const JSIException&) = default;
@@ -1453,7 +1453,7 @@ class JSI_EXPORT JSError : public JSIException {
   /// Creates a JSError referring to new \c Error instance capturing current
   /// JavaScript stack. The error message property is set to given \c message.
   JSError(Runtime& rt, const char* message)
-      : JSError(rt, std::string(message)){};
+      : JSError(rt, std::string(message)) {}
 
   /// Creates a JSError referring to a JavaScript Object having message and
   /// stack properties set to provided values.

diff --git a/packages/react-native/ReactCommon/react/renderer/core/RawValue.h b/packages/react-native/ReactCommon/react/renderer/core/RawValue.h
@@ -53,7 +53,7 @@ class RawValue {
   /*
    * Constructors.
    */
-  RawValue() noexcept : dynamic_(nullptr){};
+  RawValue() noexcept : dynamic_(nullptr) {}
 
   RawValue(RawValue &&other) noexcept : dynamic_(std::move(other.dynamic_)) {}
 
@@ -72,9 +72,9 @@ class RawValue {
   /*
    * Arbitrary constructors are private only for RawProps and internal usage.
    */
-  RawValue(const folly::dynamic &dynamic) noexcept : dynamic_(dynamic){};
+  RawValue(const folly::dynamic &dynamic) noexcept : dynamic_(dynamic) {}
 
-  RawValue(folly::dynamic &&dynamic) noexcept : dynamic_(std::move(dynamic)){};
+  RawValue(folly::dynamic &&dynamic) noexcept : dynamic_(std::move(dynamic)) {}
 
   /*
    * Copy constructor and copy assignment operator would be private and only for
@@ -109,7 +109,7 @@ class RawValue {
   template <typename T>
   bool hasType() const noexcept {
     return checkValueType(dynamic_, (T *)nullptr);
-  };
+  }
 
   /*
    * Checks if the stored value is *not* `null`.

diff --git a/packages/react-native/ReactCommon/react/renderer/core/StateData.h b/packages/react-native/ReactCommon/react/renderer/core/StateData.h
@@ -26,7 +26,7 @@ struct StateData final {
 
 #ifdef ANDROID
   StateData() = default;
-  StateData(StateData const &previousState, folly::dynamic data){};
+  StateData(StateData const &previousState, folly::dynamic data) {}
   folly::dynamic getDynamic() const;
   MapBuffer getMapBuffer() const;
 #endif