Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds base controller with crossOrigin #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

doennyl
Copy link

@doennyl doennyl commented Apr 18, 2024

we need the crossOrigin annotation, otherwise a frontend (usually running on localhost:4200 for development) can not access to the resource localhost:9000. It is considered as another domain.

@hjstorch
Copy link

Ich finde es sauberer die CrossOrigin für jede Methode einzeln zu machen; Außerdem nicht * zu setzen, sondern das über WebSecurityConfig zu machen.

@doennyl
Copy link
Author

doennyl commented Apr 18, 2024

@hjstorch : Danke für den Tipp. Ich habe es jetzt konfigurierbar gemacht. Die allowed origins habe ich weiterhin mit * drin für das Default Profil. Sollten wir es doch irgendwo ernsthafter deployen, dann können wir ein eigenes Profil dafür aufmachen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants