Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combing using Version instead of GitTag #76

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Combing using Version instead of GitTag #76

merged 1 commit into from
Oct 14, 2019

Conversation

esnible
Copy link
Contributor

@esnible esnible commented Oct 14, 2019

Resolves istio/istio#17852

Also addresses @howardjohn 's comment istio/istio#17724 (review) to improve the output of data plane versions by removing an unneeded :.

@esnible esnible requested a review from a team as a code owner October 14, 2019 15:06
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2019
@esnible esnible requested a review from howardjohn October 14, 2019 15:06
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 14, 2019
@istio-testing istio-testing merged commit 9987183 into istio:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

istioctl version does not show a single control plane version in Istio 1.3.2
4 participants
@esnible @howardjohn @googlebot @istio-testing