Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make httpbin samples work on OpenShift #47922

Merged
merged 2 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions releasenotes/notes/make-httpbin-work-ocp.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: release-notes/v2
kind: bug-fix
area: documentation
releaseNotes:
- |
**Fixed** `httpbin` sample manifests to deploy correctly on OpenShift.
18 changes: 16 additions & 2 deletions samples/extauthz/local-ext-authz.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,22 @@ spec:
- image: docker.io/kong/httpbin
imagePullPolicy: IfNotPresent
name: httpbin
# Same as found in Dockerfile's CMD but using an unprivileged port
command:
- pipenv
- run
- gunicorn
- -b
- 0.0.0.0:8080
- httpbin:app
- -k
- gevent
env:
# Tells pipenv to use a writable directory instead of $HOME
- name: WORKON_HOME
value: /tmp
ports:
- containerPort: 80
- containerPort: 8080
- image: gcr.io/istio-testing/ext-authz:latest
imagePullPolicy: IfNotPresent
name: ext-authz
Expand All @@ -88,7 +102,7 @@ spec:
ports:
- name: http
port: 8000
targetPort: 80
targetPort: 8080
selector:
app: httpbin
---
Expand Down
18 changes: 16 additions & 2 deletions samples/httpbin/httpbin-nodeport.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
ports:
- name: http
port: 8000
targetPort: 80
targetPort: 8080
selector:
app: httpbin
---
Expand All @@ -51,5 +51,19 @@ spec:
- image: docker.io/kong/httpbin
imagePullPolicy: IfNotPresent
name: httpbin
# Same as found in Dockerfile's CMD but using an unprivileged port
command:
- pipenv
- run
- gunicorn
- -b
- 0.0.0.0:8080
- httpbin:app
- -k
- gevent
env:
# Tells pipenv to use a writable directory instead of $HOME
- name: WORKON_HOME
value: /tmp
ports:
- containerPort: 80
- containerPort: 8080
18 changes: 16 additions & 2 deletions samples/httpbin/httpbin-vault.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
ports:
- name: http
port: 8000
targetPort: 80
targetPort: 8080
selector:
app: httpbin
---
Expand All @@ -51,5 +51,19 @@ spec:
- image: docker.io/kong/httpbin
imagePullPolicy: IfNotPresent
name: httpbin
# Same as found in Dockerfile's CMD but using an unprivileged port
command:
- pipenv
- run
- gunicorn
- -b
- 0.0.0.0:8080
- httpbin:app
- -k
- gevent
env:
# Tells pipenv to use a writable directory instead of $HOME
- name: WORKON_HOME
value: /tmp
ports:
- containerPort: 80
- containerPort: 8080
18 changes: 16 additions & 2 deletions samples/httpbin/httpbin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
ports:
- name: http
port: 8000
targetPort: 80
targetPort: 8080
selector:
app: httpbin
---
Expand All @@ -56,5 +56,19 @@ spec:
- image: docker.io/kong/httpbin
imagePullPolicy: IfNotPresent
name: httpbin
# Same as found in Dockerfile's CMD but using an unprivileged port
command:
- pipenv
- run
- gunicorn
- -b
- 0.0.0.0:8080
- httpbin:app
- -k
- gevent
env:
# Tells pipenv to use a writable directory instead of $HOME
- name: WORKON_HOME
value: /tmp
ports:
- containerPort: 80
- containerPort: 8080