Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[add] tolerations field to istiod #47678

Merged
merged 2 commits into from
Nov 2, 2023
Merged

[add] tolerations field to istiod #47678

merged 2 commits into from
Nov 2, 2023

Conversation

ymktmk
Copy link
Contributor

@ymktmk ymktmk commented Nov 1, 2023 •
edited
Loading

Please provide a description of this PR:

This is a pull request created from this comment.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Nov 1, 2023
@istio-testing
Copy link
Collaborator

Hi @ymktmk. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hanxiaop
Copy link
Member

hanxiaop commented Nov 1, 2023

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 1, 2023
@ymktmk
Copy link
Contributor Author

ymktmk commented Nov 1, 2023

@hanxiaop
Do I need release notes?

hanxiaop
hanxiaop reviewed Nov 1, 2023
View reviewed changes
manifests/charts/istio-control/istio-discovery/values.yaml
@@ -34,6 +34,8 @@ pilot:

affinity: {}

tolerations: []
Copy link
Member

@hanxiaop hanxiaop Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add this to the opeartor file and generate related files.

@hanxiaop
Copy link
Member

hanxiaop commented Nov 1, 2023

@hanxiaop Do I need release notes?

I think we do.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2023
@GregHanson
Copy link
Member

/test integ-security-multicluster

@ymktmk ymktmk requested a review from hanxiaop November 2, 2023 02:05
@istio-testing istio-testing merged commit 779b155 into istio:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiaop hanxiaop hanxiaop approved these changes

@costinm costinm Awaiting requested review from costinm

@jacob-delgado jacob-delgado Awaiting requested review from jacob-delgado

@Monkeyanator Monkeyanator Awaiting requested review from Monkeyanator

@GregHanson GregHanson Awaiting requested review from GregHanson

Assignees
No one assigned
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ymktmk @istio-testing @hanxiaop @GregHanson