istioctl: add waypoint integration test #47615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-policy-bot
added
area/test and release
area/user experience
release-notes-none
istio-testing
added
the
size/L
|
@GregHanson @istio/wg-test-and-release-maintainers PTAL, thanks |
GregHanson
reviewed
Nov 2, 2023
GregHanson
reviewed
Nov 2, 2023
GregHanson
reviewed
Nov 2, 2023
GregHanson
reviewed
Nov 2, 2023
| return fmt.Errorf("gateway is not ready: %v", err) | ||
| } | ||
| } else if err == nil { | ||
| return fmt.Errorf("gateway is not cleaned up") |
There was a problem hiding this comment.
nit: could this error and the one above for sa1 say something to state that it was the multi-delete that failed? Something like failed to remove multiple gateways at once, sa2 not cleaned up
There was a problem hiding this comment.
This looks better, fixed.
hanxiaop
force-pushed
the
add-wp-integration
branch
from
ab60800 to
a7de27b
Compare
GregHanson
approved these changes
Nov 3, 2023
|
kindly ping @istio/wg-test-and-release-maintainers |
jwendell
reviewed
Nov 10, 2023
| "--service-account", | ||
| sa, | ||
| }) | ||
| retry.UntilSuccessOrFail(t, func() error { |
There was a problem hiding this comment.
I think this could run faster if you create all 3 in a loop and then check for them in a separate loop
|
@jwendell Thank you for the careful code review! I think I've addressed all the comments. PTAL |
jwendell
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Follow-up to #47539. I know we have
apply/deletecommands tested in other tests, but this is for the entire command which covers all of its features, to ensure that further changes don't break any functionnalities like other istioctl commands.