Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies, and fix the validation webhook with required value #47364

Closed
wants to merge 7 commits into from
Closed

Update dependencies, and fix the validation webhook with required value #47364

wants to merge 7 commits into from
+1,663 −1,260

Conversation

hanxiaop
Copy link
Member

@hanxiaop hanxiaop commented Oct 14, 2023 •
edited
Loading

Please provide a description of this PR:
Updating client-go library results in the failure of validation tests. I've introducted ignore exception to the crdvalidator to ignore some configs that are intended to be invlid in tests. Also, fix the validation test since the invalid case may be Required value which is introduced recently in the API repo.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2023
@hanxiaop hanxiaop requested a review from a team as a code owner October 16, 2023 02:56
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2023
@hanxiaop hanxiaop added the release-notes-none Indicates a PR that does not require release notes. label Oct 16, 2023
@hanxiaop
Copy link
Member Author

/test release-notes

@hanxiaop hanxiaop mentioned this pull request Oct 16, 2023
Closed
@hanxiaop hanxiaop force-pushed the step-1-1.20 branch 2 times, most recently from 513985d to cfe536d Compare October 16, 2023 03:04
@hanxiaop hanxiaop changed the title Test update dependencies Update dependencies, and fix the invalid validation tests Oct 16, 2023
@hanxiaop hanxiaop mentioned this pull request Oct 16, 2023
Closed
@hanxiaop hanxiaop changed the title Update dependencies, and fix the invalid validation tests Update dependencies, and fix the validation/webhook with required value Oct 16, 2023
@hanxiaop hanxiaop changed the title Update dependencies, and fix the validation/webhook with required value Update dependencies, and fix the validation webhook with required value Oct 16, 2023
@hanxiaop
Copy link
Member Author

/test integ-telemetry-istiodremote

1 similar comment
@hanxiaop
Copy link
Member Author

/test integ-telemetry-istiodremote

@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2023
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2023
@hanxiaop
Copy link
Member Author

hanxiaop commented Oct 16, 2023 •
edited
Loading

This fixes tests after bumping the client-go version. Ref: #47261, also this contains Automation step 1 in #46985

@ericvn @hzxuzhonghu @howardjohn @zirain PTAL, thanks

howardjohn
howardjohn requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is skipping way to many tests. I can work on a more robust fix

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 16, 2023
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 16, 2023
@hanxiaop
Copy link
Member Author

Will be replaced by #47377; only dependency updates will be needed after its merge.

@istio-testing
Copy link
Collaborator

istio-testing commented Oct 16, 2023 •
edited
Loading

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests-arm64_istio 4867cc1 link true /test unit-tests-arm64
unit-tests_istio 4867cc1 link true /test unit-tests
integ-pilot-istiodremote_istio 4867cc1 link true /test integ-pilot-istiodremote
integ-cni_istio 4867cc1 link true /test integ-cni
integ-pilot_istio 4867cc1 link true /test integ-pilot
integ-pilot-multicluster_istio 4867cc1 link true /test integ-pilot-multicluster
integ-pilot-istiodremote-mc_istio 4867cc1 link true /test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop hanxiaop closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn

@costinm costinm

@linsun linsun

@stevenctl stevenctl

@ericvn ericvn

@hzxuzhonghu hzxuzhonghu

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanxiaop @istio-testing @howardjohn