Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert https://github.com/istio/istio/pull/43560 #44470

Merged
merged 1 commit into from
Apr 25, 2023
Merged

revert https://github.com/istio/istio/pull/43560 #44470

merged 1 commit into from
Apr 25, 2023

Conversation

kyessenov
Copy link
Contributor

@kyessenov
fix conflict
bd64ed5 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov requested review from a team as code owners April 21, 2023 18:27
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2023
@kyessenov kyessenov mentioned this pull request Apr 21, 2023
Merged
11 tasks
@kyessenov kyessenov added the release-notes-none Indicates a PR that does not require release notes. label Apr 21, 2023
@kyessenov
Copy link
Contributor Author

/retest

@ramaraochavali ramaraochavali added the do-not-merge Block automatic merging of a PR. label Apr 22, 2023
@ramaraochavali
Copy link
Contributor

@kyessenov Thanks for identifying this problem. Just put a hold to fix the issue instead of reverting. #44473 - fix. PTAL

@kyessenov
Copy link
Contributor Author

Hey Rama,
Can we proceed with the revert so that we can properly add tests to the PR you are adding? It looks like it should be easy to revert with no conflicts. The bug is blocking our build pipeline as tests crash.

@kyessenov kyessenov removed the do-not-merge Block automatic merging of a PR. label Apr 25, 2023
@istio-testing istio-testing merged commit 7e9f83f into istio:master Apr 25, 2023
@ramaraochavali
Copy link
Contributor

ramaraochavali commented Apr 26, 2023 via email

@ramaraochavali ramaraochavali mentioned this pull request Apr 26, 2023
Merged
11 tasks
@hemendrateli
Copy link
Contributor

/cherry-pick release-1.18

@istio-testing istio-testing mentioned this pull request Jul 14, 2023
Merged
@istio-testing
Copy link
Collaborator

@hemendrateli: new pull request created: #46017

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyessenov @ramaraochavali @hemendrateli @istio-testing @howardjohn