Gather proxy versions to report data plane version #17724
Conversation
esnible
requested review from
geeknoid,
howardjohn,
linsun,
rshriram and
a team
as code owners
googlebot
added
the
cla: yes
istio-testing
added
the
size/M
There was a problem hiding this comment.
Very nice, tried this out on my cluster and it worked well.
very much a nitpick:
output looks like data plane version: master-20191004-09-15: (1208 proxies), 1.3.2: (1 proxy)
Its a bit weird to have something like something: (something). I would think
data plane version: master-20191004-09-15 (1208 proxies), 1.3.2 (1 proxy)
is a bit cleaner.
|
I've used this multiple times already - extremely useful!
…On Thu, Oct 10, 2019, 6:47 AM Istio Automation ***@***.***> wrote:
@esnible <https://github.com/esnible>: The following tests *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
integ-framework-k8s-tests_istio e6df887
<e6df887>
link
<https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/17724/integ-framework-k8s-tests_istio/1852> /test
integ-framework-k8s-tests_istio
gencheck_istio e6df887
<e6df887>
link
<https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/17724/gencheck_istio/586> /test
gencheck_istio
unit-tests_istio e6df887
<e6df887>
link
<https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/17724/unit-tests_istio/1956> /test
unit-tests_istio
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#17724?email_source=notifications&email_token=AAEYGXPBS7K2TICUROKKPD3QN4W6NA5CNFSM4I7AFSGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA4MKAY#issuecomment-540591363>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXNVM3RQM233KMWSS4TQN4W6NANCNFSM4I7AFSGA>
.
|
|
@istio/wg-user-experience-maintainers please take a look |
|
@howardjohn Have you tested this with >1 Pilot? I was thinking I should rewrite this using AllPilotsDiscoveryDo() because not every pilot will have every sidecar. |
|
Oh yeah good point, this will need all pilot do I think. I don't think there will be any duplicates that way since each envoy is connected to a single pilot. |
There was a problem hiding this comment.
@esnible this is blocked by your own do-not-merge. I verified this works with multiple Pilots now
|
/test e2e-mixer-no_auth_istio |
Resolves #17172 by gathering the proxy versions so that
istioctl versionreports either the summary or detail.Uses the output mechanism and tests of istio/pkg#72