Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support on s390x #326

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Add support on s390x #326

merged 1 commit into from
Nov 25, 2020

Conversation

BbolroC
Copy link
Contributor

@BbolroC BbolroC commented Oct 14, 2020 •
edited
Loading

It is a re-submission for the previous PR in istio, part of which was overridden by this repo.

The request for this PR was made in the issue in istio.

It does not have any changes that may affect Istio users.

@BbolroC BbolroC requested a review from a team as a code owner October 14, 2020 15:19
@istio-policy-bot
Copy link

😊 Welcome @BbolroC! This is either your first contribution to the Istio common-files repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 14, 2020
@istio-testing
Copy link
Contributor

Hi @BbolroC. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2020
@BbolroC BbolroC mentioned this pull request Oct 14, 2020
Closed
@BbolroC
Copy link
Contributor Author

BbolroC commented Oct 26, 2020

Is the review still in pending? Any reasons?

@jwendell
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 25, 2020
@istio-testing istio-testing merged commit bd5e177 into istio:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwendell jwendell jwendell approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BbolroC @istio-policy-bot @istio-testing @jwendell