Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Precision #435

Open
marklundin opened this issue Sep 27, 2024 · 1 comment
Open

Key Precision #435

marklundin opened this issue Sep 27, 2024 · 1 comment

Comments

@marklundin
Copy link
Contributor

Just wondering if it makes sense to have a prevision specifier here on the key, so that you can collapse nearby vertices?

recast-navigation-js/packages/recast-navigation-three/src/utils/get-positions-and-indices.ts

Line 59 in 39ccf74

const key = `${pos.x}_${pos.y}_${pos.z}`;

@isaac-mason
Copy link
Owner

isaac-mason commented Sep 27, 2024 •
edited
Loading

That could be useful for sure, recast's voxelisation process doesn't require high precision in a lot of cases. I would be interested to see performance implications for larger inputs.

(Aside: If in creating recast-navigation/playcanvas you come across some logic in recast-navigation/three you could reuse, you could consider creating common utilities in recast-navigation/generators or recast-navigation/core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marklundin @isaac-mason