Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memory cleanup functionality and document #30

Open
isaac-mason opened this issue May 8, 2023 · 3 comments
Open

Improve memory cleanup functionality and document #30

isaac-mason opened this issue May 8, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@isaac-mason
Copy link
Owner

isaac-mason commented May 8, 2023 •
edited
Loading

Right now manual memory management with this lib is not straightforward, and not everything required is correctly exposed. Also, nothing is documented in the READMEs

This needs fixing!

todo:

  • add destroy() methods where appropriate
  • expose emscripten _free and destroy in @recast-navigation/core for more advanced use cases
  • add memory management information to READMEs
@isaac-mason isaac-mason changed the title Improve memory management and document Improve memory cleanup functionality and document May 8, 2023
@isaac-mason
Copy link
Owner Author

Progressed by: 273c456

Still requires documenting

@isaac-mason isaac-mason added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 24, 2023
@isaac-mason
Copy link
Owner Author

isaac-mason commented Sep 26, 2023 •
edited
Loading

Right now recast-navigation has some functionality for attempting to automatically free memory when c++ objects aren't correctly destroyed via FinalizationRegistry.

I'm not 100% convinced the feature is a good idea, and the current implementation isn't great. It should be removed at least for now.

@isaac-mason
Copy link
Owner Author

257e988

@isaac-mason isaac-mason mentioned this issue Apr 10, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isaac-mason