Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix core engine package cross-imports #872

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Fix core engine package cross-imports #872

wants to merge 8 commits into from
+1,199 −1,115

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Dec 20, 2024 •
edited
Loading

Summary

  • Removed special treatment of InteractableComponent in spatial input
  • Split EngineState into ReferenceSpaceState (spatial) and EngineState (ecs)
  • Move EntityTree to ecs

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@HexaField HexaField marked this pull request as draft December 24, 2024 01:44
@HexaField HexaField changed the title Remove interactable component usage from spatial package Fix core engine package cross-imports Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heysokam heysokam Awaiting requested review from heysokam heysokam is a code owner

@SamMazerIR SamMazerIR Awaiting requested review from SamMazerIR SamMazerIR is a code owner

@speigg speigg Awaiting requested review from speigg speigg is a code owner

@AidanCaruso AidanCaruso Awaiting requested review from AidanCaruso AidanCaruso will be requested when the pull request is marked ready for review AidanCaruso is a code owner

@DanielBelmes DanielBelmes Awaiting requested review from DanielBelmes DanielBelmes will be requested when the pull request is marked ready for review DanielBelmes is a code owner

@MichaelEstes MichaelEstes Awaiting requested review from MichaelEstes MichaelEstes will be requested when the pull request is marked ready for review MichaelEstes is a code owner

@dinomut1 dinomut1 Awaiting requested review from dinomut1 dinomut1 will be requested when the pull request is marked ready for review dinomut1 is a code owner

@CITIZENDOT CITIZENDOT Awaiting requested review from CITIZENDOT CITIZENDOT will be requested when the pull request is marked ready for review CITIZENDOT is a code owner

@SYBIOTE SYBIOTE Awaiting requested review from SYBIOTE SYBIOTE will be requested when the pull request is marked ready for review SYBIOTE is a code owner

@jose-galvan jose-galvan Awaiting requested review from jose-galvan jose-galvan will be requested when the pull request is marked ready for review jose-galvan is a code owner

@aditya-mitra aditya-mitra Awaiting requested review from aditya-mitra aditya-mitra will be requested when the pull request is marked ready for review aditya-mitra is a code owner

@MbfloydIR MbfloydIR Awaiting requested review from MbfloydIR MbfloydIR will be requested when the pull request is marked ready for review MbfloydIR is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HexaField