Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IR-5702] Unit Test - Spatial XR coverage: System Executes #860

Draft
wants to merge 173 commits into
base: dev
Choose a base branch
from
Draft

[IR-5702] Unit Test - Spatial XR coverage: System Executes #860

wants to merge 173 commits into from

Conversation

heysokam
Copy link
Contributor

@heysokam heysokam commented Dec 18, 2024 •
edited
Loading

TODO: Cleanup the commits list after #414 is merged into dev.
This should branch from 414, not duplicate its commit list.

Summary

Subtasks Checklist

Breaking Changes

References

https://tsu.atlassian.net/browse/IR-5702

QA Steps

heysokam and others added 30 commits October 11, 2024 19:46
@heysokam
tst: Sketch files for all spatial/XR module unit tests
e59a25f
@heysokam
fmt: Standarize the names of some XRComponents.ts components
5f7015a
@heysokam
tst: Temporarily disable the (wip) VPSSystem unit tests
ace557a
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
4f12fd9
@heysokam
tst: Move the webxr-emulator and devtool folders from ir-bot
c0db60b
@heysokam
tst: Apply changes from #583
a595339
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
8c549d8
@HexaField
fixes for webxr emulator tests
9710ab6
@heysokam
tst: Remove redundant todo note about the webxr test not passing
7223724
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
fc2640d
@heysokam
tst: Add webxr-emulator to the .prettierignore list
8f37d1b
@heysokam
tst: Add webxr-emulator to the eslint ignore list
405b472
@heysokam
fmt: Remove deprecated access of viewerEntity from Engine
29ab0a7
@heysokam
tst: Unit Tests for all static data of the spatial/xr module
2ca4737
@heysokam
tst: Document the VPSSystem definition bug
59d9978
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
9d0272b
@heysokam
tst: Activate the VPSSystem tests. Import bug is gone
bba083a
@heysokam
tst: Simplify WebXR test imports by adding requestEmulatedXRSesssion
a5d4546
@heysokam
tst: Unit Tests for XRSessionFunctions.ts (phase 1)
9d61833
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
1e3c6aa
@heysokam
tst: Unit Tests for XRSessionFunctions.ts (phase 2)
083b0b5
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
94ec5fd
@heysokam
tst: Add the webxr-emulator folders to the tsconfig.exclude array
6cfbaac
@heysokam
tst: Also add emulator.ts to the tsconfig.exclude array
09935df
@heysokam
fix: Accidental change to XRSession.onSessionEnd floor and origin
06aba0e 
LocalFloor and Origin were incorrectly removed when removing the usage of deprecated access from Engine.instance
@heysokam
tst: Add .style property to the MockRenderer canvas
d0f7756
@heysokam
tst: Add mockEmulatedXREngine helper functions
e196ff9
@heysokam
tst: Unit Tests for XRSessionFunctions.ts (phase 3)
c412ae1
@heysokam
tst: Add VSCode vitest run - spatial : Current File debug launcher
bb485fe
@heysokam
tst: Bugfix for XRSessionFunctions.ts/onSessionEnd unit tests
e05831b
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
5115920
@heysokam
tst: Unit Tests for WebXRManager.ts (phase 11)
9ace077
@heysokam
tst: Add XRWebGLBinding polyfill and mock
7dd1e84
@heysokam
tst: Unit Tests for WebXRManager.ts (phase 12)
3c0e66b
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
331d79d
@heysokam
tst: Improve the XRWebGLBinding polyfill mock
58adea3
@heysokam
tst: Unit Tests for WebXRManager.ts (phase 13)
a8ad4f9
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
8a1eced
@heysokam
tst: Unit Tests for WebXRManager.ts (phase 14)
f01370e
@heysokam
tst: Add missing XRSession assignment on the XREngine mock
0e02b64
@heysokam
tst: Fixes for todo tests at XRPersistentAnchorSystem
5433aaa
@heysokam
tst: Add immersive-ar to the list of supported WebXR emulated modes
6a70933
@heysokam
tst: Unit Tests for XRSessionFunctions.ts (phase 6) (todo fixes)
371d9dd
@heysokam
tst: Note about an 8thWall-only test case
a358ba7
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
c723cf8
@heysokam
tst: Add helper for getting the last dispatched action from history
594f832
@heysokam
tst: Unit Tests for XRSessionFunctions.ts (phase 7)
127209e
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
5d20d2d
@heysokam
Merge branch 'dev' into IR-3427-unit-test-XR-coverage-to-80
916744c
@heysokam
tst: Skip note for XRCameraViewSystem
84381bb
@heysokam
tst: Statements for XRDepthOcclusionSystem unit tests
2a7b641
@heysokam
tst: Statements for XRHapticsSystem unit tests
e9102df
@heysokam heysokam self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speigg speigg Awaiting requested review from speigg speigg will be requested when the pull request is marked ready for review speigg is a code owner

@AidanCaruso AidanCaruso Awaiting requested review from AidanCaruso AidanCaruso will be requested when the pull request is marked ready for review AidanCaruso is a code owner

@MichaelEstes MichaelEstes Awaiting requested review from MichaelEstes MichaelEstes will be requested when the pull request is marked ready for review MichaelEstes is a code owner

@MbfloydIR MbfloydIR Awaiting requested review from MbfloydIR MbfloydIR will be requested when the pull request is marked ready for review MbfloydIR is a code owner

@SamMazerIR SamMazerIR Awaiting requested review from SamMazerIR SamMazerIR will be requested when the pull request is marked ready for review SamMazerIR is a code owner

@HexaField HexaField Awaiting requested review from HexaField HexaField will be requested when the pull request is marked ready for review HexaField is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@heysokam heysokam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heysokam @HexaField