-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic bounding boxes in viewport #852
base: dev
Are you sure you want to change the base?
Fix dynamic bounding boxes in viewport #852
Conversation
…s-in-incorrect-position
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we are updating the bounding box when the debugEnabled
flag is set to true. Shouldn't the behavior of the bounding box be decoupled from whether or not the debug mode enabled? The debugEnabled
flag should only control whether or not the bounding box is visible, not when it is updated.
|
…s-in-incorrect-position
hmm, ok, then ill move the code around , but as @HexaField said, its already updated when we move the object |
the bounding box is updated after the condition here because the without the helper entity being set, the update is not performed bounding box would be recalculated with the appropriate transforms |
…s-in-incorrect-position
…s-in-incorrect-position
Correct the handling of dynamic bounding boxes by ensuring the bounding box updates appropriately when the transform changes. This improves the accuracy of the bounding box representation in the viewport.