changed the order of execution to get the highlight effect to work again #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MbfloydIR
requested review from
AidanCaruso,
DanielBelmes and
MichaelEstes
as code owners
HexaField
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Whilst this may fix the issue, we need to make sure the useEffect has the correct dependencies. Let's add !!rendererComponent.effectComposer.value as a dependency of the useEffect for the highlight effect, and ensure that it exists. Without this, it could still break (possibly in tests)
HexaField
requested changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://tsu.atlassian.net/browse/IR-6062
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps