Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-automation): 💚 stupid hack to add tag in CI #1161

Merged
merged 3 commits into from
Feb 22, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(release-automation): 🐛 push after tagging
  • Loading branch information
whizzzkid committed Feb 22, 2023
commit b6a8f4dc95affca8f8d617af562a234685a18eb5
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ jobs:
changelog-notes-type: github
- name: Tag Release
if: ${{ steps.release.outputs.release_created }} != 'true'
run: 'git tag -a v${{ steps.release.outputs.ipfs-companion--tag_name }} -m "chore(main): release ipfs-companion ${{ steps.release.outputs.ipfs-companion--tag_name }}"'

run: 'git tag -a v${{ steps.release.outputs.ipfs-companion--tag_name }} -m "chore(main): release ipfs-companion ${{ steps.release.outputs.ipfs-companion--tag_name }}" && git push origin v${{ steps.release.outputs.ipfs-companion--tag_name }}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can remove the quotes and put this on multiple lines which would be much cleaner.


release-assets:
runs-on: ubuntu-latest
Expand Down