Allow projects to upgrade to symfony/var-dumper version v6.x #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason not to merge this @rocketage ? |
skrollme
approved these changes
Dec 13, 2024
|
@dantleech it should be good to go. We have been using these changes on our project for the last 11 months without issue. |
|
I think you need to merge it @rocketage - I'm no longer able to - or maybe neither of can maybe Inviqa would consider making @rocketage a maintainer or it should be forked ... cc @andytson-inviqa 🙂 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As time marches on Symfony brings out new major versions of things. Spryker is now supporting v6.x modules, but the debug module is keeping var-dumper at version 5.x, which then has a knock on effect preventing a clean upgrade.
In our case some modules were downgraded to beta versions.
I've locally tested the debug module with var-dumper v6.4.2 and all is well, so I've created this PR for this change:
symfony/var-dumperv6.xTableNameFinder, because PHPStan was complaining so this has been updated to the correct variable forDOMNodeslevomat/coding-standard, because the latest version ofspryker/code-snifferrequires it