Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow assemble version override based on flag when using config #125

Open
matglas opened this issue Dec 10, 2024 · 3 comments · May be fixed by #133
Open

Feature: Allow assemble version override based on flag when using config #125

matglas opened this issue Dec 10, 2024 · 3 comments · May be fixed by #133
Assignees

Comments

@matglas
Copy link
Contributor

matglas commented Dec 10, 2024

It would be great if you could override or set the version of the main component when you do sbomasm assemble -v [X.Y.Z] -c [config]. This allows you to set default in config but make them specific in your CI for example base on input variables.

@riteshnoronha
Copy link
Contributor

Have u taken a look at https://github.com/interlynk-io/sbomasm?tab=readme-ov-file#edit-sboms, or is this something that if available in assemble would be better?

@matglas
Copy link
Contributor Author

matglas commented Dec 12, 2024

I have seen the edit functionality and its great. It would be a convenience to have the primary component version set the moment that you assemble it.

@viveksahu26
Copy link
Contributor

Current functionality:
We can override the default values from the config file, but there’s a strict requirement to provide all three values in the group: "name," "type," and "version." If we try to override just one value (e.g., "version"), the command enforces providing the other two values as well, which is restrictive.

For example:

$ sbomasm assemble -v "v1.0.20" -c config.yaml -o final-sbom-config.spdx.json sbomex-cdx.json sbomgr-cdx.json
Error: if any flags in the group [name version type] are set they must all be set; missing [name type]

Our desired functionality is:
When a config.yaml file is provided, users should have the flexibility to override any individual field (e.g., just "version") without being required to provide all the other grouped fields.

@viveksahu26 viveksahu26 linked a pull request Jan 1, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants