Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][InvokeSIMD][Doc] Remove revision history table #8677

Merged
merged 2 commits into from
Mar 16, 2023
Merged

[SYCL][InvokeSIMD][Doc] Remove revision history table #8677

merged 2 commits into from
Mar 16, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Mar 16, 2023 •
edited
Loading

The invoke SIMD spec revision table was out of date, and we don't use it anymore in the latest spec template, so just remove it.

@sarnex
[SYCL][InvokeSIMD][Doc] Update revision spec missed in previous commit
a59b36e 
I forgot to update this in my previous PR.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex requested a review from a team March 16, 2023 14:03
@sarnex sarnex marked this pull request as ready for review March 16, 2023 14:03
@sarnex sarnex requested a review from a team as a code owner March 16, 2023 14:03
@sarnex
Copy link
Contributor Author

sarnex commented Mar 16, 2023 •
edited
Loading

@v-klochkov Hey can you merge this? I don't think we need the spec team to review, I just forgot to update a table.

Edit: See below conversation, removing table

@Pennycook
Copy link
Contributor

@sarnex: We don't actually use these revision tables anymore (see the template here). If you wanted to, you could just remove it entirely.

Pennycook
Pennycook approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Pennycook Pennycook left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving regardless of whether the table is updated or removed. Somebody should make another pass (later) to make sure the invoke_simd documentation follows the new template.

@sarnex
Copy link
Contributor Author

sarnex commented Mar 16, 2023

@Pennycook Ah ok thanks, I'll just remove it

@sarnex
remove table
bb55d1c 
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex changed the title [SYCL][InvokeSIMD][Doc] Update revision spec missed in previous commit [SYCL][InvokeSIMD][Doc] Remove revision history table Mar 16, 2023
@bader
Copy link
Contributor

bader commented Mar 16, 2023

We don't use this table anymore, see below conversation

@sarnex, could you summarize the conversation in the description, please? PR description is used "as is" for git commit log message. "see below conversation" doesn't look useful as a git log message.

@sarnex
Copy link
Contributor Author

sarnex commented Mar 16, 2023

@bader Fixed

@bader bader merged commit 30c8062 into intel:sycl Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pennycook Pennycook Pennycook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarnex @Pennycook @bader