Skip to content

Commit

Permalink
[libc] Fix assert.h and ctype.h not being built
Browse files Browse the repository at this point in the history
The `assert.h` and `ctype.h` headers are never built despite their
entrypoints being present in the generated library. This patch adds a
dependency on these headers so that they will be built properly.

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D138142
  • Loading branch information
jhuber6 committed Nov 16, 2022
1 parent cf4f35b commit dabb751
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion libc/config/linux/aarch64/headers.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
set(TARGET_PUBLIC_HEADERS
libc.include.assert_h
libc.include.assert
libc.include.ctype
libc.include.errno
libc.include.fenv
Expand Down
2 changes: 1 addition & 1 deletion libc/config/linux/x86_64/headers.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
set(TARGET_PUBLIC_HEADERS
libc.include.assert_h
libc.include.assert
libc.include.ctype
libc.include.dirent
libc.include.errno
Expand Down
2 changes: 1 addition & 1 deletion libc/include/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ add_gen_header(
)

add_gen_header(
assert_h
assert
DEF_FILE assert.h.def
GEN_HDR assert.h
DEPENDS
Expand Down
1 change: 1 addition & 0 deletions libc/src/assert/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ add_entrypoint_object(
__assert_fail.h
assert.h
DEPENDS
libc.include.assert
libc.src.__support.OSUtil.osutil
libc.src.stdlib.abort
)
1 change: 1 addition & 0 deletions libc/src/ctype/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ add_entrypoint_object(
HDRS
isalnum.h
DEPENDS
libc.include.ctype
libc.src.__support.ctype_utils
)

Expand Down

0 comments on commit dabb751

Please sign in to comment.