Skip to content

Commit

Permalink
[SYCL][NFC] Remov unused arguments in addHostAccessor (#1830)
Browse files Browse the repository at this point in the history
Signed-off-by: Stuart Adams <stuart.adams@codeplay.com>
  • Loading branch information
nyalloc authored Jun 8, 2020
1 parent 0098eab commit 80e6c41
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
3 changes: 1 addition & 2 deletions sycl/source/detail/scheduler/graph_builder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,7 @@ Command *Scheduler::GraphBuilder::addCopyBack(Requirement *Req) {

// The function implements SYCL host accessor logic: host accessor
// should provide access to the buffer in user space.
Command *Scheduler::GraphBuilder::addHostAccessor(Requirement *Req,
const bool destructor) {
Command *Scheduler::GraphBuilder::addHostAccessor(Requirement *Req) {

const QueueImplPtr &HostQueue = getInstance().getDefaultHostQueue();

Expand Down
5 changes: 2 additions & 3 deletions sycl/source/detail/scheduler/scheduler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,11 @@ void Scheduler::removeMemoryObject(detail::SYCLMemObjI *MemObj) {
MGraphBuilder.removeRecordForMemObj(MemObj);
}

EventImplPtr Scheduler::addHostAccessor(Requirement *Req,
const bool destructor) {
EventImplPtr Scheduler::addHostAccessor(Requirement *Req) {
std::unique_lock<std::shared_timed_mutex> Lock(MGraphLock, std::defer_lock);
lockSharedTimedMutex(Lock);

Command *NewCmd = MGraphBuilder.addHostAccessor(Req, destructor);
Command *NewCmd = MGraphBuilder.addHostAccessor(Req);

if (!NewCmd)
return nullptr;
Expand Down
4 changes: 2 additions & 2 deletions sycl/source/detail/scheduler/scheduler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ class Scheduler {
/// \param Req is the requirement to be updated.
/// \return an event which indicates when these nodes are completed
/// and host accessor is ready for use.
EventImplPtr addHostAccessor(Requirement *Req, const bool Destructor = false);
EventImplPtr addHostAccessor(Requirement *Req);

/// Unblocks operations with the memory object.
///
Expand Down Expand Up @@ -472,7 +472,7 @@ class Scheduler {
/// Enqueues a command to create a host accessor.
///
/// \param Req points to memory being accessed.
Command *addHostAccessor(Requirement *Req, const bool destructor = false);
Command *addHostAccessor(Requirement *Req);

/// [Provisional] Optimizes the whole graph.
void optimize();
Expand Down

0 comments on commit 80e6c41

Please sign in to comment.