Skip to content

Commit

Permalink
Undo react patch that enabled error rethrowing in workers
Browse files Browse the repository at this point in the history
This is done in favor of setting ErrorBoundary in the render function on the side of remote client
which allows to listen to error on globalThis by reportError-ing in componentDidCatch
  • Loading branch information
misha-reyzlin-shopify committed Oct 21, 2022
1 parent a35cf5c commit b6dc21a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 38 deletions.
7 changes: 1 addition & 6 deletions packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,7 @@
"require": "./host.js"
}
},
"sideEffects": [
"./build/cjs/error-polyfill.cjs",
"./build/esm/error-polyfill.mjs",
"./build/esnext/error-polyfill.esnext",
"./src/error-polyfill.ts"
],
"sideEffects": false,
"devDependencies": {
"@types/react-dom": "^17.0.0",
"react": "^17.0.0",
Expand Down
31 changes: 0 additions & 31 deletions packages/react/src/error-polyfill.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/react/src/render.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import './error-polyfill';
import type {ReactElement} from 'react';
import type {RemoteRoot} from '@remote-ui/core';
import type {RootTag} from 'react-reconciler';
Expand Down

0 comments on commit b6dc21a

Please sign in to comment.