Fix invalid waitForEvent expression not failing run #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amh4r
requested review from
tonyhb,
darwin67 and
BrunoScheufler
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jpwilliams
approved these changes
Dec 11, 2024
…d-expressions-should-immediately-fail-waitforevent
…mediately-fail-waitforevent
|
LGTM 🥳 |
jpwilliams
deleted the
aaron/inn-4152-invalid-expressions-should-immediately-fail-waitforevent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix invalid
waitForEventexpression not causing the run to fail. Instead, thewaitForEventwould timeout.The fix was a simple expression validation and returned error, but more refactoring was necessary to make history look correct. There's till an outstanding issue with the
step.waitForEventmissing in the timeline, but that's a more significant change.Testing
Existing automated tests and manual testing.
