Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add managed connector spec to helm charts #1595

Closed
wants to merge 21 commits into from

Conversation

simlay
Copy link
Contributor

@simlay simlay commented Sep 10, 2021

This is a sub PR to #1499.

@simlay simlay requested a review from sehz September 10, 2021 17:42
Copy link
Contributor

@nacardin nacardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly need to remove copy pasta references to SPU/SPG

@simlay simlay requested review from sehz and nacardin September 15, 2021 00:55
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to add to changelog

crates/fluvio-connector/Cargo.toml Outdated Show resolved Hide resolved
crates/fluvio-connector/src/config.rs Outdated Show resolved Hide resolved
crates/fluvio-connector/src/config.rs Outdated Show resolved Hide resolved
crates/fluvio-connector/Cargo.toml Outdated Show resolved Hide resolved
crates/fluvio-connector/src/main.rs Outdated Show resolved Hide resolved
crates/fluvio-connector/src/main.rs Outdated Show resolved Hide resolved
@simlay simlay requested a review from sehz September 21, 2021 18:45
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few minor nits. Also add to change log

crates/fluvio-connector/Cargo.toml Show resolved Hide resolved
crates/fluvio-connector/Cargo.toml Outdated Show resolved Hide resolved
crates/fluvio-connector/Cargo.toml Outdated Show resolved Hide resolved
crates/fluvio-connector/src/connector/create.rs Outdated Show resolved Hide resolved
crates/fluvio-connector/test-config.yaml Outdated Show resolved Hide resolved
crates/fluvio-connector/README.md Outdated Show resolved Hide resolved
crates/fluvio-connector/test-config.yaml Outdated Show resolved Hide resolved
@sehz
Copy link
Contributor

sehz commented Sep 21, 2021

bors r+

bors bot pushed a commit that referenced this pull request Sep 21, 2021
@bors
Copy link

bors bot commented Sep 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Add managed connector spec to helm charts [Merged by Bors] - Add managed connector spec to helm charts Sep 21, 2021
@bors bors bot closed this Sep 21, 2021
bors bot pushed a commit that referenced this pull request Sep 25, 2021
The last release we mistakenly missed publishing a few crates bc we missed on increasing their version numbers.

`fluvio-protocol-codec` gets a patch bump to `0.3.3` from test changes. #1579
`fluvio-dataplane-protocol` gets a minor bump to `0.7.0` from public enum changes. #1595

Dependent crates were all patch bumped too (if we publish them).

---

This needs to be merged, and crates published before PR #1684 can pass
bors bot pushed a commit that referenced this pull request Sep 25, 2021
The last release we mistakenly missed publishing a few crates bc we missed on increasing their version numbers.

`fluvio-protocol-codec` gets a patch bump to `0.3.3` from test changes. #1579
`fluvio-dataplane-protocol` gets a minor bump to `0.7.0` from public enum changes. #1595

Dependent crates were all patch bumped too (if we publish them).

---

This needs to be merged, and crates published before PR #1684 can pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants