-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add managed connector spec to helm charts #1595
Conversation
crates/fluvio-controlplane-metadata/src/managed_connector/k8/spec.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-controlplane-metadata/src/managed_connector/k8/spec.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly need to remove copy pasta references to SPU/SPG
crates/fluvio-sc/src/services/public_api/managed_connectors/fetch.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-sc/src/services/public_api/managed_connectors/fetch.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-sc/src/services/public_api/managed_connectors/fetch.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-controlplane-metadata/src/managed_connector/k8/spec.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-controlplane-metadata/src/managed_connector/k8/spec.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-sc/src/services/public_api/managed_connectors/fetch.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-sc/src/services/public_api/managed_connectors/fetch.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-sc/src/services/public_api/managed_connectors/fetch.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to add to changelog
…connector-helm-chart
…connector-helm-chart
…connector-helm-chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Few minor nits. Also add to change log
bors r+ |
Pull request successfully merged into master. Build succeeded: |
The last release we mistakenly missed publishing a few crates bc we missed on increasing their version numbers. `fluvio-protocol-codec` gets a patch bump to `0.3.3` from test changes. #1579 `fluvio-dataplane-protocol` gets a minor bump to `0.7.0` from public enum changes. #1595 Dependent crates were all patch bumped too (if we publish them). --- This needs to be merged, and crates published before PR #1684 can pass
The last release we mistakenly missed publishing a few crates bc we missed on increasing their version numbers. `fluvio-protocol-codec` gets a patch bump to `0.3.3` from test changes. #1579 `fluvio-dataplane-protocol` gets a minor bump to `0.7.0` from public enum changes. #1595 Dependent crates were all patch bumped too (if we publish them). --- This needs to be merged, and crates published before PR #1684 can pass
This is a sub PR to #1499.